actions / upload-artifact

MIT License
3.25k stars 732 forks source link

Unable to upload artifact when using v4.4.2 #630

Closed shankarRaman closed 1 month ago

shankarRaman commented 1 month ago

What happened?

We use proxy for all outbound calls from our self-hosted runners. We noticed that with release 4.4.2 the calls made to the proxy are not passing the credentials which are getting denied by the proxy server. When using 4.4.1 the action passed the credentials without any issue.

What did you expect to happen?

Expect the action to upload artifacts without issues

How can we reproduce it?

We are using self-hosted runners with proxy that has authentication and the credentials are stored as secrets

Anything else we need to know?

No response

What version of the action are you using?

v4.4.2

What are your runner environments?

self-hosted, linux

Are you on GitHub Enterprise Server? If so, what version?

No response

pulkitanz commented 1 month ago

This is breaking a lot of workflows

robherley commented 1 month ago

👋 We're looking into this. Please use the v4 tag which has been updated to point to v4.4.1, or you can use that version explicitly to mitigate.

joshmgross commented 1 month ago

This should be fixed in https://github.com/actions/upload-artifact/releases/tag/v4.4.3, we're working on validating that fully before updating the v4 major version tag.

robherley commented 1 month ago

The v4 tag has been updated to point to v4.4.3

robherley commented 1 month ago

The fix has been out for almost a week now, closing