actions / upload-artifact

MIT License
3.25k stars 732 forks source link

[feat req] Allow slashes in artifact name #647

Open BernhardKoschicek opened 4 days ago

BernhardKoschicek commented 4 days ago

What would you like to be added?

At OpenAtlas we are using branch names with slashes, which is a widespread git naming convention.

Sadly, when using e.g. a branch name like feature/text-annotation actions/upload-artifact@v4 fails with following error message:

Error: The artifact name is not valid: OpenAtlas-feature/text-annotation-auto-deploy-values-yaml. Contains the following character:  Forward slash /

Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /

These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

The example take from the OpenAltas development (https://github.com/acdh-oeaw/OpenAtlas).

Why is this needed?

We understand, that allowing slashes cause other problems, but it would be nice if action work with standard git naming conventions.