search

active-calculus / active-calculus-vector

Vector calculus materials to accompany Active Calculus Multivariable
5 stars 10 forks source link

Final edits to Chapter 12 #71

Closed mitchkeller closed 1 year ago

mitchkeller commented 1 year ago

I still have to do 12.12, so let's call this WIP until I push a commit this weekend or Monday with those edits. Just ran out of steam for today. (Also it looks like there may be merge conflicts here, so I'll try to push a commit that prevents those once I can see what the issues are.)

mitchkeller commented 1 year ago

This should be ready to merge. No massive changes in 12.12, but I did add another short activity at the end, since we only had one (non-preview) activity.

nelong commented 1 year ago

I'll check this out in the morning. I have the I tro to the exercises I wanted that I will merge into this PR.

On Mon, Aug 7, 2023, 5:56 PM Mitchel T. Keller @.***> wrote:

This should be ready to merge. No massive changes in 12.12, but I did add another short activity at the end, since we only had one (non-preview) activity.

— Reply to this email directly, view it on GitHub https://github.com/active-calculus/active-calculus-vector/pull/71#issuecomment-1668677748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4HO42MFD5KAUKI2GSTAQTXUFXCVANCNFSM6AAAAAA3EX5ZFA . You are receiving this because your review was requested.Message ID: @.***>

nelong commented 1 year ago

Something weird is happening with some of the webwork problems. I'm trying to figure out what is happening. A bunch of the first problems in different sections are showing up as a different problem (which would not be applicable to the section...)

On Tue, Aug 8, 2023 at 12:22 PM Mitchel T. Keller @.***> wrote:

@.**** commented on this pull request.

These look good to me. Looks like things are ready for you to merge.

— Reply to this email directly, view it on GitHub https://github.com/active-calculus/active-calculus-vector/pull/71#pullrequestreview-1567802096, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4HO4356HGCG6TDFAHKX3LXUJYVJANCNFSM6AAAAAA3EX5ZFA . You are receiving this because your review was requested.Message ID: @.*** com>

nelong commented 1 year ago

Can you build locally or deploy and check if the first exercise of sections in chapter 12 correspond to the listed one in the ptx?

On Tue, Aug 8, 2023 at 12:31 PM Nicholas Long @.***> wrote:

Something weird is happening with some of the webwork problems. I'm trying to figure out what is happening. A bunch of the first problems in different sections are showing up as a different problem (which would not be applicable to the section...)

On Tue, Aug 8, 2023 at 12:22 PM Mitchel T. Keller < @.***> wrote:

@.**** commented on this pull request.

These look good to me. Looks like things are ready for you to merge.

— Reply to this email directly, view it on GitHub https://github.com/active-calculus/active-calculus-vector/pull/71#pullrequestreview-1567802096, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4HO4356HGCG6TDFAHKX3LXUJYVJANCNFSM6AAAAAA3EX5ZFA . You are receiving this because your review was requested.Message ID: @.*** com>

nelong commented 1 year ago

@mitchkeller This PR looks good after my changes in the last commit. Let me know when figures get rebuilt and I can check things out again.

mitchkeller commented 1 year ago

@nelong Pushed what should be the final commit for this. If you want to build before checking, you should regenerate WW representations with pretext generate -t html webwork and then pretext build -q html. We had some xml:id issue that I think was masking out a WW or at least I got an error when I did a build before regenerating WW. If all looks good, then you should be able to merge this.