search

active-hash / active_hash

A readonly ActiveRecord-esque base class that lets you use a hash, a Yaml file or a custom file as the datasource
MIT License
1.2k stars 179 forks source link

Why is version 2.2 dependent on Ruby 2.4 and Rails 5? #180

Closed hunterae closed 4 years ago

okuramasafumi commented 5 years ago

Ruby 2.4 has not reached EOL, so it should be supported IMO.

hunterae commented 5 years ago

@okuramasafumi , I don't have a problem with supporting Ruby 2.4. My issue is that this gem requires Ruby 2.4 or greater and Rails 5 or greater, and I'm not convinced the latest changes require those restrictions.

syguer commented 4 years ago

Hi @hunterae . I pick up some our philosophy.

  1. We don't support all ActiveRecord versions by one code
  2. We decide to change stable version for supporting several ActiveRecord versions
  3. We don't want to support Ruby and Rails reached EOL

As a result, our gem restrict Ruby and Rails version like now. If you want to use new feature on old version, apply monkey patch, or PR is welcome if it works correctly.

hunterae commented 4 years ago

@syguer , while I can appreciate trying to encourage using the latest and greatest, is there really anything in the codebase that wouldn't be supported by say Ruby 2.0 or Rails 4? Why not just setup the testing Matrix for Travis CI to ensure that the whole test suite passes on different versions of Ruby and Rails 4.

I believe most companies have probably made the leap to Rails 4, there are some (the one I work for included) that are slowly working our way up to 5.