search

active-hash / active_hash

A readonly ActiveRecord-esque base class that lets you use a hash, a Yaml file or a custom file as the datasource
MIT License
1.2k stars 179 forks source link

CI against Ruby 3.0 #224

Closed tbotaq closed 3 years ago

tbotaq commented 3 years ago

Hi.

I've tried some fix to make the CI status green against Ruby 3.

Removing :rbx specifications from .gemfile

It seems that the version specification of rubysl doesn't allow Ruby 3.0 (See: the failing CI's log ). I've tried to find some web source about 3.0 support of rubysl but I could not.

By the way, it also seems that our CI doesn't list rbx as its build target.

So I found it not necessary to get the problem fixed, and removed platforms :rbx specifications from all the .gemfile. Is it OK ? I'm not certain if it's ok for this repository.

I'm glad if you see the commit comments to figure out what I did. Thank you.

ref: https://github.com/zilkey/active_hash/issues/225

tbotaq commented 3 years ago
tbotaq commented 3 years ago

Thank you for the comment !

Let me ask,

delete any old gem files

Q: Which gemfiles should we regard as old ?

README says,

To make users' lives easier, please maintain support for: Ruby 2.4 ActiveRecord/ActiveSupport from 5.0 through edge

So I thought we shouldn't remove any of these existing gemfiles, whose versions are 5.0 through edge .

rails_5.0.gemfile
rails_5.1.gemfile
rails_5.2.gemfile
rails_6.0.gemfile
tbotaq commented 3 years ago

So, could anybody merge this PR ? :octocat:

tbotaq commented 2 years ago

Thank you for merging.