support i18n - Githubissues

active-hash / active_hash

A readonly ActiveRecord-esque base class that lets you use a hash, a Yaml file or a custom file as the datasource

MIT License

1.2k stars 179 forks source link

support i18n #230

Closed ryu-sato closed 1 month ago

ryu-sato commented 3 years ago

Hi, I am hoping that ActiveHash will support i18n.

Since the reason why #170 does not merge for a long time is that it needs tests, I created a new PR that adds tests based on #170.

[x] bundle exec rspec passed

kbrock commented 1 month ago

I think a test would be to add a localization file in specs and verify that the translated name comes through.

Also, could you remove the merge branch and rebase this whole branch onto master? Then you can just squash your two commits. If you do not know how to do, I may be able to do this while I merge.

ryu-sato commented 1 month ago

@kbrock Thank you for your feedback. I have addressed your feedback.