Closed kbrock closed 2 years ago
@syguer I had merged a few PRs and wanted to make sure that the suite was still green. When I downloaded to run it, things were in a little off. Hope you like these changes.
I can merge if you are too busy, but would prefer to get your ok.
update:
update:
@yujideveloper do you want me to pull out the rspec changes (autorun
and expect
) for an easy merge?
Do you also consider the YAML
change an easy merge?
@kbrock
do you want me to pull out the rspec changes (autorun and expect) for an easy merge?
I think it's better to pull out, but I think it's okay as it is.
Do you also consider the YAML change an easy merge?
I think it is easy merge, but I have one concern in https://github.com/active-hash/active_hash/pull/246#discussion_r853352555.
update:
YAML.load
to YAML.unsafe_load
@kbrock now that we've cut over to GitHub Actions, is this PR still required?
Overview
I made the test run locally on my machine.
Dependencies
Versions in matrix
I chose the max ruby version that runs with the corresponding rails version. This seemed to cover most of the ruby and rails versions.
Since all ruby versions under 3.0 were tested in at least one configuration, it seemed logical to only add ruby 3.0 to the matrix.
All supported versions of rails were added to the matrix. I did hold off on 7.0 since that build does not run and that is best for another
I'm hoping this is a nice mix between testing every version of rails, every version of ruby, and not taking too long / using up too many resources for testing redundant configurations.
What was out of scope
While I did add a rails 7.0 gemspec, fixing the suite was out of scope. Once that runs, we can uncomment the line in the travis.yml
Sources