Closed yujideveloper closed 2 years ago
@yujideveloper do you know what the business process is around the review/merge?
Am I allowed to review and merge your changes? Or do we need 2 different people on that? With this project, I worry that requiring 2 different reviewers would mean nothing gets merged
@kbrock
Sorry, late reply.
do you know what the business process is around the review/merge?
I don't know it in this project.
Am I allowed to review and merge your changes? Or do we need 2 different people on that? With this project, I worry that requiring 2 different reviewers would mean nothing gets merged
I think it's better to have two different reviewers. But as you say, I think nothing will be merged in this project now.
I fixed two deprecation warnings below.
DEPRECATION WARNING: Rails 7.0 has deprecated Enumerable.sum in favor of Ruby's native implementation available since 2.4. Sum of non-numeric elements requires an initial argument.
DEPRECATION WARNING: Time#to_s(:number) is deprecated. Please use Time#to_fs(:number) instead.