Closed kbrock closed 1 year ago
@adampal @flavorjones I can't merge this. Needs a review from another maintainer. Can one of you +1 this and then I'll release?
In the future I will skip the PR and see if I can push directly to master
. (Prefer not to do that but...)
I did try this from the command line but...
[master] active_hash $ git push upstream master
remote: Resolving deltas: 100% (8/8), completed with 4 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: At least 1 approving review is required by reviewers with write access.
To https://github.com/zilkey/active_hash.git
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/zilkey/active_hash.git'
heh. Maybe it is my old 'upstreamreference, but I think the protections around
git` may make this difficult.
After you are here, could you +1 #254 ? We dropped travis a while ago and that broke local rake
(default: rspec
).
Again, I'm not allowed to fix that since I put in the PR.
Is this still waiting to go up to Rubygems or is there more to be done? This release seems long overdue, I'm excited to switch to an official version rather than from source.
@rgarver Ryan, thanks for the polite ping.
Release notes for v3.2.0