active-logic / activelogic-cs

Behavior Trees and Case Logic for C#7
GNU Affero General Public License v3.0
106 stars 7 forks source link

Misc #80

Closed eelstork closed 3 years ago

eelstork commented 3 years ago
codecov-commenter commented 3 years ago

Codecov Report

Merging #80 (f47a589) into master (1bf7daf) will decrease coverage by 0.16%. The diff coverage is 75.00%.

:exclamation: Current head f47a589 differs from pull request most recent head 8fa791a. Consider uploading reports for the commit 8fa791a to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##            master      #80      +/-   ##
===========================================
- Coverage   100.00%   99.83%   -0.17%     
===========================================
  Files           55       55              
  Lines          612      612              
  Branches       107      108       +1     
===========================================
- Hits           612      611       -1     
- Partials         0        1       +1     
Impacted Files Coverage Δ
Src/Decorators/Cooldown.cs 100.00% <ø> (ø)
Src/Decorators/Drive.cs 100.00% <ø> (ø)
Src/Decorators/InOut.cs 100.00% <ø> (ø)
Src/Decorators/Init.cs 100.00% <ø> (ø)
Src/Decorators/Interval.cs 100.00% <ø> (ø)
Src/Decorators/Latch.cs 100.00% <ø> (ø)
Src/Decorators/Once.cs 100.00% <ø> (ø)
Src/Decorators/ResetCriterion.cs 100.00% <ø> (ø)
Src/Decorators/Timeout.cs 100.00% <ø> (ø)
Src/Decorators/Wait.cs 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1bf7daf...8fa791a. Read the comment docs.

eelstork commented 3 years ago

In my opinion, stepping a null Task should raise, not fail silently. Since the motivation for changing this is unclear right now, I'll try reverting before committing the diff.