search

activeadmin-plugins / active_admin_datetimepicker

:calendar: active_admin_datetimepicker gem
MIT License
72 stars 48 forks source link

Fix missing CSS-styling in production mode #44

Closed workgena closed 5 years ago

workgena commented 5 years ago

This PR is intended to fix styling error:

before after
Before After
workgena commented 5 years ago

@Fivell can you please check out why Travis CI does not run?

Expected — Waiting for status to be reported

Fivell commented 5 years ago

@workgena this is github issue , they have some problems now https://twitter.com/githubstatus

workgena commented 5 years ago

Looks like we have deprecated(not supported) configuration of Travis:

https://docs.travis-ci.com/user/legacy-services-to-github-apps-migration-guide/

As of May 2, 2018 we are moving toward having repositories integrated via a GitHub App instead of GitHub Services which will no longer be supported as of October 1, 2018.

Fivell commented 5 years ago

@workgena are u able to migrate ?

workgena commented 5 years ago

@Fivell not, I can't login to Travis "activeadmin-plugins" namespace

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.5%) to 94.774% when pulling a7731bfea4eb25e6e21004f95413bcbde84cb6ae on workgena:compatibilty_with_activeadmin_1.3 into 081593e5b67017efd5aa0c335088e3697262e1ab on activeadmin-plugins:master.

workgena commented 5 years ago

The problem was with bin/rails assets:precompile. It loses the content of "jquery.xdan.datetimepicker.css". The only working solution, I managed to find, is to use ActiveAdmin register_stylesheet method. It is DEPRECATED and will be removed in 2.0 version. But, for now, it works correctly. So I propose to use it.

# config/initializers/active_admin_datetimepicker.rb
ActiveAdmin.setup do |config|
  config.register_stylesheet 'jquery.xdan.datetimepicker.css'
end
Fivell commented 5 years ago

@workgena 👍 feel free to bump new version

benjaminwood commented 5 years ago

FYI, it's not released yet but active admin has undeprecated register_stylesheet

https://github.com/activeadmin/activeadmin/pull/5662

Guess it paid off to wait until active_admin provided a 'solution' :smile: