loosen activeadmin restriction to allow 2.0

activeadmin-plugins / active_admin_datetimepicker

:calendar: active_admin_datetimepicker gem

MIT License

72 stars 48 forks source link

loosen activeadmin restriction to allow 2.0 #50

Closed iarie closed 5 years ago

iarie commented 5 years ago

https://github.com/activeadmin/activeadmin/blob/master/CHANGELOG.md

Activeadmin 2.0 do not сontain any major changes except ruby 2.3 support drop, this gem should be fine

coveralls commented 5 years ago

Coverage increased (+1.3%) to 96.109% when pulling 9250cf6ae8ebe44890c2190cafe6004ed0584aed on iarie:patch-1 into 9404671577855a346f61369b704ab6fd9cade133 on activeadmin-plugins:master.

coveralls commented 5 years ago

Coverage increased (+1.04%) to 95.817% when pulling 52c4807d637b7b5b260587648ff472fea0cea3c6 on iarie:patch-1 into 9404671577855a346f61369b704ab6fd9cade133 on activeadmin-plugins:master.

deivid-rodriguez commented 5 years ago

Hi @iarie, sorry if the changelog is confusing.

The ruby 2.3 support drop has not yet been released. The list of changes in the 2.0 release can be found mainly under the 2.0.0.rc1 entry. The fact that the 2.0.0 entry says "No changes" means that there were no user visible changes between 2.0.0.rc2 and 2.0.0 final.

workgena commented 5 years ago

I'll take a look at this PR tomorrow :sun_with_face:

iarie commented 5 years ago

@deivid-rodriguez hi, yes but there are no major changes in rc1 section as well, so I thought this gem should work fine on AA 2.0

deivid-rodriguez commented 5 years ago

@deivid-rodriguez hi, yes but there are no major changes in rc1 section as well, so I thought this gem should work fine on AA 2.0

Ah, ok. Since you said that the main breaking change was dropping support for ruby 2.3, I thought you had misunderstood the changelog :+1:. It sounds like the only thing needed to get CI green would be to drop Rails 4.2 support in this plugin just like AA did.

workgena commented 5 years ago

Firstly, @iarie thanx for contribution.

I've found what was the problem with ActiveAdmin 2.0 and fixed in followed commit.

Then I decided to remove 2.3 ruby support due to:

Ruby Maintenance Branches

Ruby 2.3

status: eol release date: 2015-12-25 EOL date: 2019-03-31

Rails Supported versions

For major security issues, all releases in the current major series, and the last release in the additional major series will receive patches and new versions. This is currently 5.2.x, 5.1.x, 5.0.x and 4.2.x.

workgena commented 5 years ago

I'll do version bump after merging this PR. Before that I want to check it manually.

workgena commented 5 years ago

Checked it manually. Works fine.

@iarie @deivid-rodriguez If you do not have any other comments on this PR, I'll merge it.

iarie commented 5 years ago

Thank you, @workgena!