fix: add placeholder option to input_html_options

activeadmin-plugins / active_admin_datetimepicker

:calendar: active_admin_datetimepicker gem

MIT License

72 stars 48 forks source link

fix: add placeholder option to input_html_options #52

Closed Cusp2356 closed 5 years ago

Cusp2356 commented 5 years ago

Allows default ActiveAdmin functionality of From and To placeholders in datetime range input elements

coveralls commented 5 years ago

Coverage increased (+0.02%) to 94.946% when pulling 050f58d70cb89f90da07cbb4b9916f9ed14672bf on emailintegrations:datetimepicker_add_placeholder into 36e27f641938647299b94aa3b68c8c07b707c037 on activeadmin-plugins:master.

workgena commented 5 years ago

@mantoszew Thank you for proposal. It is deferentially a bug. An you fix is working find. But I found that other input_html options are ignored as well. So here is #53 fix for both issues.

This PR is closed in favor of #53

workgena commented 5 years ago

Version 0.7.1 has been published to the RubyGems with this fix.