Replace chromedriver-helper with webdrivers

activeadmin-plugins / active_admin_datetimepicker

:calendar: active_admin_datetimepicker gem

MIT License

72 stars 48 forks source link

Replace chromedriver-helper with webdrivers #64

Closed adamkiczula closed 4 years ago

adamkiczula commented 4 years ago

I saw https://github.com/activeadmin-plugins/active_admin_datetimepicker/issues/62 had a help wanted tag so I figured I'd take a crack at it.

coveralls commented 4 years ago

Coverage decreased (-0.02%) to 95.42% when pulling 27a27469034663fd40c2a5425719e49e4d11d73b on adamkiczula:replace-chromedriver-helper into ee259aa48d4944b411fb8839a5eaf4868bcb2315 on activeadmin-plugins:master.

adamkiczula commented 4 years ago

This is my first exposure to coveralls, but if I'm reading it right, it seems to be a false alarm. It did get me thinking though, should the generated test rails apps be included in the coverage numbers - seems less than desirable.

workgena commented 4 years ago

Hi, @adamkiczula

Thank you for the contribution :gem:

Have a nice weekend :balloon: