search

activeadmin-plugins / active_admin_datetimepicker

:calendar: active_admin_datetimepicker gem
MIT License
72 stars 48 forks source link

Drop dependency "xdan-datetimepicker-rails" #72

Closed workgena closed 1 year ago

workgena commented 3 years ago

Background

Currently "active_admin_datetimepicker" has strong dependency on shekibobo/xdan-datetimepicker-rails

It provides Rails-wrapper for xdan/datetimepicker JS-library.

xdan-datetimepicker-rails is abandoned and is not updates since 2016.

The last update for xdan/datetimepicker JS-lib is dated 2020 year.

Proposition

Remove dependency on "shekibobo/xdan-datetimepicker-rails" and be dependant directly to "xdan/datetimepicker".

Or, create PR with update to xdan-datetimepicker-rails.

Related issues

senid231 commented 3 years ago

i think we should just remove dependency, write instruction about how to install it via webpacker/sprockets and release major version (because it's a breaking change)