search

activeadmin-plugins / active_admin_import

:paperclip: active_admin_import is based on activerecord-import gem - the most efficient way to import for ActiveAdmin
http://activeadmin-plugins.github.io/active_admin_import
MIT License
183 stars 101 forks source link

remove support for ruby 2.1 #155

Closed Fivell closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+2.6%) to 97.778% when pulling 065e56f461482cdfb53e8671d2def3800f0eed83 on Fivell-patch-1 into 30f064aa785751690fab1033a71c4e214b647567 on master.

workgena commented 6 years ago

When running RSpec locally it will run "Rails 4.2.8"(by default).

https://github.com/activeadmin-plugins/active_admin_import/blob/30f7ff4c297a455e4fd0b3f21f3b19b51cc6b431/Gemfile#L9-L10

Since the support of it was dropped, should we replace this with 5.0.0 ?

workgena commented 6 years ago

Got it #157