search

activeadmin-plugins / active_admin_import

:paperclip: active_admin_import is based on activerecord-import gem - the most efficient way to import for ActiveAdmin
http://activeadmin-plugins.github.io/active_admin_import
MIT License
184 stars 101 forks source link

Add ActiveAdminImport::Exception #175

Closed linqueta closed 4 years ago

linqueta commented 4 years ago

How was discussed in the issue #174 , this exception will let who consumes the gem create a custom error to threat it as a failure in import.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.05%) to 97.826% when pulling e4e23c9f482ecffb0a6cff552f3f48e1f6180d6a on linqueta:add-active-admin-import-exception into ff3a6e917f6d1dd21d6b58e1bffce5354ccc4d7a on activeadmin-plugins:master.

linqueta commented 4 years ago

Is happening this error for Rails version 5.2.2.1:

Failure/Error: require 'active_admin'
NameError:
  uninitialized constant Responders::FlashResponder::ActionView
  Did you mean?  ActionDispatch

Do I have to do something?

Fivell commented 4 years ago

@linqueta hard to say, will take a look next week

linqueta commented 4 years ago

@linqueta hard to say, will take a look next week

I'll look too on this weekend.

linqueta commented 4 years ago

@linqueta hard to say, will take a look next week

Hey @Fivell , I fixed the problem in #176 , it was simple, just requiring 'action_view'. If you approve, I'll rebase it.

Fivell commented 4 years ago

@linqueta good please squash commits and lets merge/release