search

activeadmin-plugins / active_admin_import

:paperclip: active_admin_import is based on activerecord-import gem - the most efficient way to import for ActiveAdmin
http://activeadmin-plugins.github.io/active_admin_import
MIT License
183 stars 101 forks source link

Add compatibility for Ruby 3.0 #190

Closed clinejj closed 2 years ago

clinejj commented 3 years ago

This addresses two issues where method calls needed to be updated due to changes in Ruby 3.0 argument passing. I also updated the CI configuration to add Ruby 3 and newer bugfix builds of Ruby/Rails, but happy to revert those changes if needed. I also added sassc-rails to the Gemfile, as development/testing doesn't work out of the box without it.

Fixes https://github.com/activeadmin-plugins/active_admin_import/issues/189

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.01%) to 97.974% when pulling 5eb0fcc4c3a88e0ca48f6d98d27214de780ed233 on Shelf-Life:ruby-3-compat into 1c7601fcccff35bb4217430e3fd0626312f64f2f on activeadmin-plugins:master.

clinejj commented 2 years ago

@Fivell is it possible to get a review on this?

clinejj commented 2 years ago

@Fivell or @workgena possible to get this reviewed?

workgena commented 2 years ago

Hi @clinejj

I was out of Ruby-world for while. If nobody look at this PR for next few weeks, I'll try to get to it (it looks safe).

PS: Thank you for also updating the Travis CI matrix.

clinejj commented 2 years ago

No worries, thanks!