Primary key fix, dependency and specs fix for inner test app

activeadmin / activeadmin-mongoid

ActiveAdmin hacks to support Mongoid

MIT License

192 stars 210 forks source link

Primary key fix, dependency and specs fix for inner test app #104

Closed xfynx closed 7 years ago

xfynx commented 7 years ago

Fixed primary key (which was presented in previous PRs)
Fixed specs and some bugs remains from rails3 to rails4 migration. The problems was caused by old inner test_app, which is used for smoke testing inside gem, so i fixed them.
Added gemfile.lock into repository for successful deployment at travis-ci (mainly on ruby 1.9.3)

xfynx commented 7 years ago

I don't know why your travis failed to deploy at 1.9.3, mine as you can see in this branch are okay https://travis-ci.org/xfynx/activeadmin-mongoid/builds/198804498 Branch (and build, i guess) is the same. So could you please rebuild this? Maybe it is inner glitch, cause my builds (several last at least) are okay

boie0025 commented 7 years ago

@xfynx We've since updated a lot of the libraries used in this gem. Do you have any interest in merging master in to this branch and cleaning that up, or perhaps creating a top level branch for legacy applications still using libraries relevant to this PR?

xfynx commented 7 years ago

@boie0025 commits related more to legacy version, so yes, second variant is more preferable

boie0025 commented 7 years ago

OK I will merge into rails4 branch.

boie0025 commented 7 years ago

Perfect, thanks @xfynx!