Closed ngan closed 1 year ago
Surprising this hasn't come up before. Thanks! Tests are running now.
Hey @javierjulio I think I fixed the build. This problem surfaced when I tried to use sidekiqswarm
which I guess preloads all the gems without loading the rails application.
I think the next version of Rails is going to be strict about gems that are inadvertently loading Rails concerns without using load hooks: https://github.com/rails/rails/pull/46047
@javierjulio @deivid-rodriguez please let me know if I need to do anything else to get this merged and released. Happy to help!
@javierjulio @deivid-rodriguez just wanted to kindly bump this 🙇
@ngan I will get to this soon, thank you.
Patch coverage: 100.00
% and project coverage change: +0.29
:tada:
Comparison is base (
83107dc
) 91.36% compared to head (250063d
) 91.66%.:exclamation: Current head 250063d differs from pull request most recent head 5478006. Consider uploading reports for the commit 5478006 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@javierjulio this is ready for another look! 🙇
Thus PR does a few things:
lib/rails.rb
tolib/railtie.rb
to follow modern conventions.action_view
loading. Only then do we want to register the template handler.send :include
to justinclude
since this gem supports only version of Ruby where it’s a public method.The way it's current done is problematic for me because it attempts to reference
ActionView
before it's loaded by the application itself (config/application.rb
). Requiring therails
gem doesn't actually load all the rails gems.