search

activeadmin / arbre

An Object Oriented DOM Tree in Ruby
MIT License
762 stars 74 forks source link

issue 474: fix kwarg deprecation warning for method_missing method in… #475

Closed irenehakes closed 1 year ago

irenehakes commented 1 year ago

Resolves the deprecation warning seen here:

gems/arbre-1.5.0/lib/arbre/element.rb:183: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

Fixes the same potential issue on line 179 as well.

See Issue #474

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (83107dc) 91.36% compared to head (b07b5af) 91.36%.

:exclamation: Current head b07b5af differs from pull request most recent head 6a04029. Consider uploading reports for the commit 6a04029 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #475 +/- ## ======================================= Coverage 91.36% 91.36% ======================================= Files 17 17 Lines 475 475 ======================================= Hits 434 434 Misses 41 41 ``` | [Impacted Files](https://codecov.io/gh/activeadmin/arbre/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin) | Coverage Δ | | |---|---|---| | [lib/arbre/element.rb](https://codecov.io/gh/activeadmin/arbre/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2VsZW1lbnQucmI=) | `91.83% <66.66%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

andrewlangston commented 1 year ago

@javierjulio @deivid-rodriguez could you kindly review this PR? Ruby 2.7 is EOL so we'll want to merge this to maintain compatibility with Ruby 3. Thanks!