activeadmin / arbre

An Object Oriented DOM Tree in Ruby
MIT License
756 stars 74 forks source link

Remove table tag defaults #516

Closed javierjulio closed 12 months ago

javierjulio commented 12 months ago

These are unnecessary for a long time now as they can be controlled easily through CSS. It would be best to have no overrides for these elements (other p/para due to the name clash).

This PR and #517 will be in a major (v2) release due to being a breaking change.

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.90 :tada:

Comparison is base (6887c96) 91.66% compared to head (f88f279) 92.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #516 +/- ## ========================================== + Coverage 91.66% 92.56% +0.90% ========================================== Files 17 17 Lines 480 471 -9 ========================================== - Hits 440 436 -4 + Misses 40 35 -5 ``` | [Impacted Files](https://app.codecov.io/gh/activeadmin/arbre/pull/516?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin) | Coverage Δ | | |---|---|---| | [lib/arbre/html/html5\_elements.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/516?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvaHRtbDVfZWxlbWVudHMucmI=) | `100.00% <ø> (+29.41%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.