activeadmin / arbre

An Object Oriented DOM Tree in Ruby
MIT License
764 stars 74 forks source link

Add ActiveSupport 7.1 as default setup #537

Closed tomascco closed 12 months ago

tomascco commented 1 year ago

I made this PR based on #314, so:

I ran rake spec with all Gemfiles, but got a Deprecation Warning that a didn't succeed in solving:

DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.

(called from <top (required)> at arbre/spec/rails/rails_spec_helper.rb:5)

One solution that I found is to define the config on spec/rails/rails_spec_helper.rb:

# from
Combustion.initialize! :action_controller,
                       :action_view

# to
Combustion.initialize! :action_controller, :action_view do # line 5
  config.active_support.cache_format_version = 7.1
end
codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (5f9cc4e) 92.52% compared to head (708df54) 92.52%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #537 +/- ## ======================================= Coverage 92.52% 92.52% ======================================= Files 17 17 Lines 468 468 ======================================= Hits 433 433 Misses 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.