activeadmin / arbre

An Object Oriented DOM Tree in Ruby
MIT License
764 stars 74 forks source link

Revert "Include blank attributes in HTML output (#517)" #541

Closed javierjulio closed 12 months ago

javierjulio commented 12 months ago

This reverts commit cf59b8ff98eaff99d0f05b0cacc948b422c03073.

This is a temporary revert to allow us to create another v1 release from master branch which was switched to v2. We want to redo this change anyway.

codecov[bot] commented 12 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7aee5a8) 92.52% compared to head (521deda) 91.66%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #541 +/- ## ========================================== - Coverage 92.52% 91.66% -0.86% ========================================== Files 17 17 Lines 468 480 +12 ========================================== + Hits 433 440 +7 - Misses 35 40 +5 ``` | [Files](https://app.codecov.io/gh/activeadmin/arbre/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin) | Coverage Δ | | |---|---|---| | [lib/arbre/html/attributes.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvYXR0cmlidXRlcy5yYg==) | `100.00% <100.00%> (ø)` | | | [lib/arbre/html/tag.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvdGFnLnJi) | `93.68% <100.00%> (ø)` | | | [lib/arbre/html/html5\_elements.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvaHRtbDVfZWxlbWVudHMucmI=) | `70.58% <44.44%> (-29.42%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.