activeadmin / arbre

An Object Oriented DOM Tree in Ruby
MIT License
764 stars 74 forks source link

Remove table tag defaults #542

Closed javierjulio closed 11 months ago

javierjulio commented 12 months ago

These are unnecessary for a long time now as they can be controlled easily through CSS. It would be best to have no overrides for these elements (other than p/para due to the name clash).

This will be in a major (v2) release due to being a breaking change.

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8164455) 91.57% compared to head (ae866e6) 92.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #542 +/- ## ========================================== + Coverage 91.57% 92.48% +0.91% ========================================== Files 17 17 Lines 475 466 -9 ========================================== - Hits 435 431 -4 + Misses 40 35 -5 ``` | [Files](https://app.codecov.io/gh/activeadmin/arbre/pull/542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin) | Coverage Δ | | |---|---|---| | [lib/arbre/html/html5\_elements.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvaHRtbDVfZWxlbWVudHMucmI=) | `100.00% <ø> (+29.41%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.