search

activeadmin / arbre

An Object Oriented DOM Tree in Ruby
MIT License
756 stars 74 forks source link

Fix RuboCop Layout and Style configuration #550

Closed tagliala closed 8 months ago

tagliala commented 8 months ago

Add the missing options to Layout and Style departments.

Using the configuration from inherited_resources

Please review with "Hide whitespace" option enabled

image
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a29cfc0) 92.39% compared to head (25ba7d8) 94.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #550 +/- ## ========================================== + Coverage 92.39% 94.34% +1.95% ========================================== Files 17 17 Lines 460 460 ========================================== + Hits 425 434 +9 + Misses 35 26 -9 ``` | [Files](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin) | Coverage Δ | | |---|---|---| | [lib/arbre/context.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2NvbnRleHQucmI=) | `100.00% <ø> (ø)` | | | [lib/arbre/element.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2VsZW1lbnQucmI=) | `91.83% <ø> (ø)` | | | [lib/arbre/element/builder\_methods.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2VsZW1lbnQvYnVpbGRlcl9tZXRob2RzLnJi) | `100.00% <ø> (ø)` | | | [lib/arbre/element\_collection.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2VsZW1lbnRfY29sbGVjdGlvbi5yYg==) | `81.81% <ø> (ø)` | | | [lib/arbre/html/attributes.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvYXR0cmlidXRlcy5yYg==) | `100.00% <ø> (ø)` | | | [lib/arbre/html/class\_list.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvY2xhc3NfbGlzdC5yYg==) | `100.00% <ø> (ø)` | | | [lib/arbre/html/document.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvZG9jdW1lbnQucmI=) | `95.23% <100.00%> (+42.85%)` | :arrow_up: | | [lib/arbre/html/tag.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvdGFnLnJi) | `93.68% <ø> (ø)` | | | [lib/arbre/html/text\_node.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL2h0bWwvdGV4dF9ub2RlLnJi) | `94.44% <ø> (ø)` | | | [lib/arbre/rails/forms.rb](https://app.codecov.io/gh/activeadmin/arbre/pull/550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeadmin#diff-bGliL2FyYnJlL3JhaWxzL2Zvcm1zLnJi) | `88.63% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tagliala commented 8 months ago

@javierjulio this PR only changes whitespaces, there should not be a decrease in coverage, the code should not be covered already

javierjulio commented 8 months ago

@tagliala did you have anything else here outside the concern of the document meta tag issue? If not, I'm ready to review and approve. All looks good. Thanks!