search

activeadmin / inherited_resources

MIT License
2.7k stars 393 forks source link

Make lockfile platforms easier to maintain #916

Closed tagliala closed 5 months ago

tagliala commented 5 months ago

This should work equally well and has less churn when maintainers upgrade their OS or switch platforms.

Recent versions of Bundler will "optimize" this, and as long as no variants specific to the macOS version exist, it will lock only arch + OS, but not the specific macOS version.

These should not get added in the future again as long as we use a recent enough version of Bundler, and for this reason locked Bundler has been bumped to 2.5.11

Ref: activeadmin/activeadmin#8344

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.91%. Comparing base (fca75e3) to head (715cf31).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #916 +/- ## ======================================= Coverage 98.91% 98.91% ======================================= Files 14 14 Lines 555 555 ======================================= Hits 549 549 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tagliala commented 5 months ago

I would like to add credits in the commit to @deivid-rodriguez, but I don't know how to do that

javierjulio commented 5 months ago

@tagliala no worries, he won't mind. He'll just be happy that this is making its way to other projects too. Thank you for doing this. I appreciate it.

deivid-rodriguez commented 5 months ago

@tagliala Indeed I don't mind at all, thanks for adding this actually :)!

For next time, the way I usually do this is to find user name and email of the user I want to credit through git log, then I amend the commit including authorship. See https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors.