search

activeadmin / inherited_resources

MIT License
2.7k stars 393 forks source link

Configure Minitest/Focus cop #917

Closed tagliala closed 5 months ago

tagliala commented 5 months ago

Added in v0.35, prevents a warning in the console

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.91%. Comparing base (64bb516) to head (a30950c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #917 +/- ## ======================================= Coverage 98.91% 98.91% ======================================= Files 14 14 Lines 555 555 ======================================= Hits 549 549 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tagliala commented 5 months ago

Here it is: https://github.com/activeadmin/inherited_resources/actions/runs/9329161308/job/25681264557#step:5:49

  The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file.

  Please also note that you can opt-in to new cops by default by adding this to your config:
    AllCops:
      NewCops: enable
  Minitest/Focus: # new in 0.35
    Enabled: true
javierjulio commented 5 months ago

@tagliala ah ok, I thought you meant a warning from minitest in regards to that rule but noticed no changes here. I understand now. Thank you!