search

activeguild / vite-plugin-sass-dts

This is a plugin that automatically creates a type file when using the CSS module type-safely.
MIT License
120 stars 18 forks source link

Adding sass as a peer dependency? #49

Closed nksfrank closed 2 years ago

nksfrank commented 2 years ago

looking through the project while trying to determine if it's possible to use this package for pure .css files I saw what looks to me like sass is required: https://github.com/activeguild/vite-plugin-sass-dts/blob/8456f52921c35d723a24888314059b1b97df59e0/src/css.ts#L86

Should this project add peerDependencies.sass: * to let anyone using this know that sass is required when installing the package with a package manager?

activeguild commented 2 years ago

@nksfrank Hi, Thanks contact. Yes, it is. We think it is best to specify peerDependencies.sass: *.

activeguild commented 2 years ago

Fixed and latest version is now available.