Improve pre-signed URL handling for Azure

dgaloop commented 3 months ago

🚀 🚀 Pull Request

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.90%. Comparing base (0afbf61) to head (e8783b8). Report is 1 commits behind head on main.

Files	Patch %	Lines
deeplake/core/storage/azure.py	80.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2796 +/- ## ========================================== - Coverage 84.47% 83.90% -0.57% ========================================== Files 231 231 Lines 26468 26469 +1 ========================================== - Hits 22358 22209 -149 - Misses 4110 4260 +150 ``` | [Flag](https://app.codecov.io/gh/activeloopai/deeplake/pull/2796/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeloopai) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/activeloopai/deeplake/pull/2796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeloopai) | `83.90% <80.00%> (-0.57%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeloopai#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.