Improved numpy conversion error messages

activeloopai / deeplake

Database for AI. Store Vectors, Images, Texts, Videos, etc. Use with LLMs/LangChain. Store, query, version, & visualize any AI data. Stream data in real-time to PyTorch/TensorFlow. https://activeloop.ai

https://activeloop.ai

Mozilla Public License 2.0

7.88k stars 607 forks source link

Improved numpy conversion error messages #2809

Closed nvoxland-al closed 3 months ago

nvoxland-al commented 3 months ago

🚀 🚀 Pull Request

Impact

[X] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

The error messages from numpy.frombuffer() are vague. Catch and rethrow the exception with more context to improve troubleshooting

Also adds more context to error messages coming from a section of the transform logic used in eval()

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is `45.45455%` with `6 lines` in your changes are missing coverage. Please review.	Files	Patch %	Lines
deeplake/core/transform/transform.py	42.85%	4 Missing :warning:
deeplake/core/sample.py	50.00%	2 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!