Check function passed to dataset.filter() is correctly configured

nvoxland-al commented 3 months ago

🚀 🚀 Pull Request

[X] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

When defining a filter like this:

@deeplake.compute
def filter_fn(sample):
    return sample.t1.data()["value"] == "Hello"

view = ds.filter(filter_fn())

if you forget the ()in view = ds.filter(filter_fn()) your data is not filtered.

This PR looks for that pattern and auto-calls the function for you.

It is still valid to call:

def filter_fn(sample):
    return sample.t1.data()["value"] == "Hello"

view = ds.filter(filter_fn)

which doesn't annotate filter_fn and therefore should NOT have () on the value passed to ds.filter()

sonarcloud[bot] commented 3 months ago

codecov[bot] commented 3 months ago

Attention: Patch coverage is `50.00000%` with `1 lines` in your changes are missing coverage. Please review.	Files	Patch %	Lines
deeplake/core/query/filter.py	50.00%	1 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!