Added dictionary based filtering for IN - Githubissues

activeloopai / deeplake

Database for AI. Store Vectors, Images, Texts, Videos, etc. Use with LLMs/LangChain. Store, query, version, & visualize any AI data. Stream data in real-time to PyTorch/TensorFlow. https://activeloop.ai

https://activeloop.ai

Mozilla Public License 2.0

8.08k stars 616 forks source link

Added dictionary based filtering for IN #2893

Closed istranical closed 3 months ago

istranical commented 3 months ago

🚀 🚀 Pull Request

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[x] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Added dictionary based filtering where if target is a list, it's compared via IN
Cleaned up tests slightly, and removed TQL string comparisons in some tests. The query results are either right or wrong, and should be assessed via output correctness. We likely shouldn't test string parsing or TQL syntax in the vector store module.

Things to be aware of

Things to worry about

Additional Context

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud