search

activemerchant / active_merchant

Active Merchant is a simple payment abstraction library extracted from Shopify. The aim of the project is to feel natural to Ruby users and to abstract as many parts as possible away from the user to offer a consistent interface across all supported gateways.
http://activemerchant.org
MIT License
4.54k stars 2.5k forks source link

Failing Cybersource tests #325

Closed tfwright closed 12 years ago

tfwright commented 12 years ago

I'm trying to add some functionality to CyberSource but the remote tests pertaining to tax calculation seem to be failing in the current master:

  1) Failure:
test_successful_tax_calculation(RemoteCyberSourceTest) [/Users/tfwright/Code/active_merchant/test/remote/gateways/remote_cyber_source_test.rb:80]:
<"Successful transaction"> expected but was
<"One or more fields contains invalid data">.

  2) Failure:
test_successful_tax_calculation_with_nexus(RemoteCyberSourceTest) [/Users/tfwright/Code/active_merchant/test/remote/gateways/remote_cyber_source_test.rb:101]:
<"Successful transaction"> expected but was
<"One or more fields contains invalid data">.
ntalbott commented 12 years ago

We can't help much with failing remote tests, especially if there aren't shared credentials for the gateway. One possibility in this case is that the tax stuff requires a feature that isn't enabled on your Cybersource account, but that's just a guess.

tfwright commented 12 years ago

I figured as much. Thanks for the tip--you may be right. As far as submitting a pull request for new functionality, would it be a problem if there are failing remote tests for unrelated functionality?

ntalbott commented 12 years ago

No, no issue.

ntalbott commented 12 years ago

Closing this out, but feel free to re-open and/or send a Pull Request.