search

activemerchant / offsite_payments

A simple and unified API to handle dozens of different offsite payment pages.
MIT License
169 stars 200 forks source link

Lock Gemfile-shopify to money 0.14.x #353

Closed zbriscoe closed 3 years ago

zbriscoe commented 3 years ago

The Gemfile.shopify file doesn't specify a version of money to use. Not having that can lead to issues.

A particular problem currently caused by this (and what is prompting me to specify it) is that Money 0.15 was just released which is causing several tests to fail.

Let's keep the minor version locked for now to prevent breakages introduced by functionality changes.

We can bump the money gem to 0.15 in a follow up PR, for now we need to create a release for a fix for Gestpay and get the master CI green.

pi3r commented 3 years ago

Please do, I have concerns that locking this version without a follow-up fix will cause breakage in applications that use both offsite-payments and money.

Oh don't you worry, only core uses both, no biggie.

zbriscoe commented 3 years ago

@bdewater Do you have someone who can look at this immediately? Without setting the version the CI will continue to fail on master. And I don't have the bandwidth or context for this right now unfortunately.

If there are serious concerns and there is someone available shortly to do this I can wait to release for a bit until we can bump to 0.15. Question though, if there were any real problems in core we'd be experiencing them now since this gem (already) doesn't play nice with 0.15, right?