Closed BradleyGoulding closed 9 months ago
I have updated the icon and corrected the errors, notably, missing a pi-prefix in the title, and ensuring the background is white.
Hi @BradleyGoulding, could you please rebase this branch with activemerchant/master to resolve the conflicts.
Thank you
I have updated my local and reapplied my changes. Please confirm all is in order. Apologies, Github closed the PR in the processing of fetching changes.
Corrected SVG with XML tag that was missing
Why are you adding this icons?
I'm adding/updating this icon(s) because it improves visibility on our stores
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?