Closed kevinverschoor closed 4 months ago
Made the change! I thought I had done SVGO already but appearently had forgotton, apologies!
Hi @kevinverschoor we recently addressed a ruby version issue causing the test failure with this PR , therefore we need you to rebase your branch kevinverschoor:stoov
with activemerchant/master
to fix the CI failure. Thanks.
Hi @kevinverschoor , would you be able to re-base this PR? We are unable to move forward unless it gets re-based.
Thanks
Hi @kevinverschoor , would you be able to re-base this PR? We are unable to move forward unless it gets re-based.
Thanks
re-based this PR and resolved any merge conflicts
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) Adeniyi Adeyemi
What's the expected date of this change to deploy on Shopify? We're waiting for this logo to release a payment app, so asap.