Closed sakifutamura closed 9 months ago
@sakifutamura This payment method already exists as sepa_bank_transfer
. You can go ahead and use that.
@Jacquesattaque SEPA Direct Debit is different than SEPA bank transfer; SEPA Direct Debit is a reusable payment method intended for recurring payments, while SEPA Bank Transfers are one-time direct wire transfers. We need to be able to change the hover label used for the payment icon, depending on which SEPA payment method is being used, so we don't introduce confusion to our customers. I suggest that this is similar to how Klarna has four distinct payment methods listed here with the same logo; because Klarna, Klarna Pay Now, Klarna Pay Later, and Klarna Slice It are distinct payment methods. Could you please re-consider your decision to close this PR? :pray:
@sakifutamura Thanks for the context. Yes, you can resubmit this — please use the same icon as for SEPA bank transfer though. It looks like the size of the logo is different in yours.
Why are you adding this icons?
I'm adding this icon because this gem currently has an icon for SEPA Bank Transfer, but not for SEPA Direct Debit
Help us identify yourself
Link to the brand guidelines: https://www.europeanpaymentscouncil.eu/document-library/other/sepa-logo-visual-identity-guidelines
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?