Closed sakifutamura closed 8 months ago
@Jacquesattaque Sorry! My text editor was automatically removing trailing whitespace on save
Hi @sakifutamura, we addressed a ruby version issue causing the test failure with this PR , therefore we need you to rebase your branch sakifutamura:sepa-dd
with activemerchant/master
to fix the CI failure. Thanks.
@adeniyiao Done! thanks!
Why are you adding this icons?
I'm adding this icon because this gem currently has an icon for SEPA Bank Transfer, but not for SEPA Direct Debit (context)
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?