Closed trustring closed 7 months ago
Hi @andy-anhtruong @trustring , we recently addressed a ruby version issue causing the test failure with this PR , therefore we need you to rebase your branch trustring:todopay
with activemerchant/master
to fix the CI failure. Thanks.
@adeniyiao cc @trustring
I have rebased my branch trustring:todopay
with activemerchant/master
. It seem CI passed. Please help us to review again and approve.
Thank you!
@adeniyiao We are preparing to publish Todo payment soon, so please assist us in deploying it as soon as possible. Thank you!
Hi @trustring , it doesn't look like we were able to include it in time for yesterday's release. For the sake of time, I've scheduled an ad-hoc release for next Wednesday just to get you live sooner then the Feb 7th release date.
Why are you adding this icons?
I'm adding this icon because we have recently launched a Todopay payment app on Shopify.
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify? As soon as possible.