Closed dalindev closed 7 months ago
You have some automated checks to clear. Is there a version of this icon that could be submitted on a white background?
Is it because the background causing the CI to fail? I will ask our designer for a white background version. Just submitted an alternative version.
@dalindev No, the background wasn't causing the CI failure. I'll tag @adeniyiao to help if you can't find the source of the error.
@Jacquesattaque , @adeniyiao , yeah are we able to run the test locally? Not sure what is missing, thank you
@Jacquesattaque Hey 👋 , anyone can help with the CI thing? is it because of the svg or? thanks because we are going to launch with a customer in Jan, 2024 🙇
cc @dannye0231 are you able to take a look?
cc @dannye0231 are you able to take a look?
I took a look into the errors but can't seem to narrow down why exactly those tests are failing. I'll ask @adeniyiao to take a further look with me when we're prepping for the next payment icon release.
It seems the test failed before even started. If we don't have a solution, I can re-submit this with a new branch. thanks
@adeniyiao
Hi @dalindev , we are investigating the issue as it affects some other PR. We'll get back to you before end of week with an update.
Hi @dalindev, we addressed the ruby version issue causing the failure in this repo, therefore we need you to rebase your branch real-simple-labs:simplepay
with activemerchant/master
to fix the CI failure. Thanks.
Hi @dalindev, we addressed the ruby version issue causing the failure in this repo, therefore we need you to rebase your branch
real-simple-labs:simplepay
withactivemerchant/master
to fix the CI failure. Thanks.
Hey @adeniyiao , thanks for the update. I just did a rebase, could you run the CI for this one, thank you!
@hellicarusprime, thanks for the update. When can we expect this to be merged and start using the logo? Thanks.
Hi @dalindev The release is scheduled for the first Wednesday of every month.
@hellicarusprime, it appears that there haven't been any releases yet this month. Could you please merge this one? We're preparing for a Shopify merchant to go live with Simple Pay next week, and including the new logo in this month's release would be crucial for their launch, thanks for your help! 🎉 🙇
Cc: @adeniyiao
Hi @dalindev , we are planning the next release for this month for mid next week.
Hi @dalindev, I tried to re-base this PR for you but I do not have access to the source Git repository. Would you be able to re-base this PR for me?
Thank you
@dannye0231 just updated, thanks!
Hi @dannye0231 👋,
We have a merchant scheduled to go live next week, and we're eager to know if this will be merged today. We've been inquiring about the merge timeline since last week. Considering we initiated this process over a month ago. Thank you for your attention to this matter.
CC: @hellicarusprime @Jacquesattaque @adeniyiao
Hi @dalindev , it doesn't look like we were able to include it in time for yesterday's release. For the sake of time, I've scheduled an ad-hoc release for next Wednesday just to get you live sooner then the Feb 7th release date.
@dannye0231 appreciated the help, I also added you to our forked repo, I will be checking early next week then. thanks again! ❤️ 🙇
@dannye0231 just did a rebase, let me know if this is good 🚀 , thanks
@dannye0231 in the admin dashboard I can see the SimplePay icon, but in the checkout it is like this, is this normal? thanks
@dalindev are you able to try again and tell me if it now displays? I see that the final commit into Prod occurred at 1:44pm EST.
If its still not displaying, then can you please provide me with your test Shop ID?
@dannye0231 just checked, all is good now, probably CDN cache or something. thank you! 🙇 👍
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify? ASAP 👍