Closed Maxi-TD closed 8 months ago
hi @Jacquesattaque, I've already corrected the border, can you help me with failed checks?
cc @dannye0231 are you able to take a look?
Hi @dannye0231! Could you take a look at it please?
Hi @Maxi-TD , we addressed a ruby version issue in this repo, therefore we need you to rebase your branch Maxi-TD:clip
with activemerchant/master
to fix the CI failure. Thanks.
It's already solved. Thanks @adeniyiao
Hey @Maxi-TD, I just noticed that you still have the double border issue that you said you fixed. Apologies, I assumed it was done. Can you please update?
@hellicarusprime I'm sorry about that, I'm going to fix it. Thanks!
@Maxi-TD Can you please make the necessary changes as soon as possible?
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?