activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons
MIT License
144 stars 422 forks source link

Add DCEP icon #1117

Closed liuqiangliuqiang6 closed 7 months ago

liuqiangliuqiang6 commented 8 months ago

Why are you adding this icons?

I'm adding/updating this icon(s) because ..

Help us identify yourself

Link to the brand guidelines:

Checklist to add new icons

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<YOUR SVG CODE>

<br>
<!-- TODO: insert your icon here -->
<YOUR SVG CODE>
</br

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

liuqiangliuqiang6 commented 8 months ago

@Jacquesattaque Apple Pay and Google Pay icons already exist Why can't we use them in Payment Methods?

Jacquesattaque commented 8 months ago

cc @adeniyiao for when you're back.

liuqiangliuqiang6 commented 8 months ago

企业微信截图_17029488983476

We can't find the Apple Pay and Google Pay icons here

Jacquesattaque commented 8 months ago

@liuqiangliuqiang6 What app are you building?

liuqiangliuqiang6 commented 8 months ago

@Jacquesattaque We are building a payment app

Jacquesattaque commented 8 months ago

@liuqiangliuqiang6 These aren't available to all partners. Who is the app for, and who is your contact at Shopify?

liuqiangliuqiang6 commented 8 months ago

企业微信截图_17030393901278

@Jacquesattaque We are Oceanpayment, this is our App (https://apps.shopify.com/oceanpayment), the contact persons is sunjay.chopra sunjay.chopra@shopify.com; altmash.shaikh <altmash.shaikh@shopify.com >.

Jacquesattaque commented 8 months ago

cc @dannye0231 do we have to manually provision this for partners?

dannye0231 commented 8 months ago

cc @dannye0231 do we have to manually provision this for partners?

For wallets (Apple Pay/GooglePay) the Partner should reach out to their Partner Manager to get it properly provisioned within their Partner profile. Once it has been confirmed and enabled, the wallet payment types will be visible. Keep in mind that it can take up to several hours to show up once it has been enabled.

liuqiangliuqiang6 commented 8 months ago

@dannye0231 Do we need to contact the partner manager ourselves?

dannye0231 commented 8 months ago

@dannye0231 Do we need to contact the partner manager ourselves?

Yes, the Partner Manager would be your contact for these types of requests. They would in-turn reach out to the required resources internally if needed. but usually its a pretty straightforward process for them to get additional wallets activated under your Partner profile.

adeniyiao commented 8 months ago

Hi @liuqiangliuqiang6

We addressed a ruby version issue causing the test failure with this PR , therefore we need you to rebase your branchliuqiangliuqiang6:master with activemerchant/master to fix the CI failure. Thanks.

hellicarusprime commented 8 months ago

Some of the checks are failing Cc: @adeniyiao

adeniyiao commented 8 months ago

@liuqiangliuqiang6 will have to rebase as per comment here https://github.com/activemerchant/payment_icons/pull/1117#issuecomment-1877639478

liuqiangliuqiang6 commented 8 months ago

@adeniyiao Is there any problem I need to solve now?