Closed liuqiangliuqiang6 closed 7 months ago
@Jacquesattaque Apple Pay and Google Pay icons already exist Why can't we use them in Payment Methods?
cc @adeniyiao for when you're back.
We can't find the Apple Pay and Google Pay icons here
@liuqiangliuqiang6 What app are you building?
@Jacquesattaque We are building a payment app
@liuqiangliuqiang6 These aren't available to all partners. Who is the app for, and who is your contact at Shopify?
@Jacquesattaque We are Oceanpayment, this is our App (https://apps.shopify.com/oceanpayment), the contact persons is sunjay.chopra sunjay.chopra@shopify.com; altmash.shaikh <altmash.shaikh@shopify.com >.
cc @dannye0231 do we have to manually provision this for partners?
cc @dannye0231 do we have to manually provision this for partners?
For wallets (Apple Pay/GooglePay) the Partner should reach out to their Partner Manager to get it properly provisioned within their Partner profile. Once it has been confirmed and enabled, the wallet payment types will be visible. Keep in mind that it can take up to several hours to show up once it has been enabled.
@dannye0231 Do we need to contact the partner manager ourselves?
@dannye0231 Do we need to contact the partner manager ourselves?
Yes, the Partner Manager would be your contact for these types of requests. They would in-turn reach out to the required resources internally if needed. but usually its a pretty straightforward process for them to get additional wallets activated under your Partner profile.
Hi @liuqiangliuqiang6
We addressed a ruby version issue causing the test failure with this PR , therefore we need you to rebase your branchliuqiangliuqiang6:master
with activemerchant/master
to fix the CI failure. Thanks.
Some of the checks are failing Cc: @adeniyiao
@liuqiangliuqiang6 will have to rebase as per comment here https://github.com/activemerchant/payment_icons/pull/1117#issuecomment-1877639478
@adeniyiao Is there any problem I need to solve now?
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?