Closed rixwansyed closed 7 months ago
it again failed any urgent help why its doing. I have fresh forked and cloned repo and created new branch and pull request
Hi @rixwansyed, it failed due to a different issue as highlighted in the screenshot
My Pull request has passed all the checks, What is the next step to our icon published in Shopify?
Hi @rixwansyed, it failed due to a different issue as highlighted in the screenshot
We have resolved all issues, can you guide how the changes will be merged?
Any update or help is appreciated @adeniyiao
hi @adeniyiao still waiting for the update, any idea when this will be merged as all the checks has been passed.
Hi @rixwansyed , we are scheduling another delta release this Wednesday, we will include this PR
Hi @rixwansyed , we are scheduling another delta release this Wednesday, we will include this PR
Thanks for the update, much appreciated @adeniyiao
Hi @rixwansyed , I can't add this yet as PR needs to be reviewed and approved.
cc @hellicarusprime
Hi @rixwansyed , I can't add this yet as PR needs to be reviewed and approved.
cc @hellicarusprime
Is there any estimated time, as my management is asking for estimated time.
Hi @rixwansyed , I can't add this yet as PR needs to be reviewed and approved. cc @hellicarusprime
Is there any estimated time, as my management is asking for estimated time.
Hi @rixwansyed I've just approved this.
cc @adeniyiao
any update when the next PR is happening @adeniyiao
Hi @rixwansyed , the next release is schedule for Feb 7
I can not see our icon in the Payment methods in our payment extension. @adeniyiao can you guide what is the next step.
Hi @rixwansyed , apologies for the delay, the release process is not fully completed, there's a pending deployment that should be done by EOD today and the icon will show up after.
thank @adeniyiao for the update, looking forward
Hi @rixwansyed , it's now deployed. Please check and confirm. Regards
Thanks @adeniyiao for the update, we are able to see the icon now.
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
![Uploading cashew-visa-example.svg…]()
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?