Add wave mobile money icon

activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons

MIT License

144 stars 422 forks source link

Add wave mobile money icon #1132

Closed tolu-paystack closed 6 months ago

tolu-paystack commented 7 months ago

Checklist

[x] All icons have a corresponding entry in db/payment_icons.yml
[x] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
[x] I have optimized the icon with SVGO
[x] I am confident that all icons are clear and easy to read/understand
[x] I have provided a link to the brand icon’s brand guidelines whenever possible.

If this pull request is not adding new icons, you can remove this checklist.

hellicarusprime commented 7 months ago

@tolu-paystack Can you update the name in the YML file? It shouldn't have any special characters, including dashes, spaces or underscores.

tolu-paystack commented 6 months ago

Hey @hellicarusprime is this a new requirement? I see several older icons in the yml file have underscores in their names Screenshot 2024-02-12 at 09 24 14

adeniyiao commented 6 months ago

@tolu-paystack , previously this was this case for older PRs. However, going forward, the image file name and name in the yml file should be same and must be lowercase alpha characters only.

tolu-paystack commented 6 months ago

Ah gotcha @adeniyiao. I've made the required changes

tolu-paystack commented 6 months ago

@hellicarusprime please re-review

adeniyiao commented 6 months ago

Hi @tolu-paystack , could you please rebase your branch tolu-paystack:wave_mobile_money with activemerchant/master to resolve the conflicts.

Thanks

tolu-paystack commented 6 months ago

Hey @adeniyiao I messed up the rebase and somehow closed this PR. I'll just create a new branch and submit a new PR