activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons
MIT License
144 stars 422 forks source link

Update SimplePay icon (v1.1) #1136

Closed dalindev closed 7 months ago

dalindev commented 7 months ago

Why are you adding this icons?

I'm adding/updating this icon(s) because ..

Help us identify yourself

Link to the brand guidelines:

Checklist to add new icons

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

Updated screenshot Jan 29th, 2024:

Screenshot 2024-01-29 at 11 08 15 AM

Screenshot 2024-01-29 at 11 07 40 AM

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: white; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" role="img" viewBox="0 0 38 24" width="38" height="24" fill="none" aria-labelledby="pi-simplepay" version="1.1"><title id="pi-simplepay">Simple Pay</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z" fill="#000"/><rect x="1" y="1" width="36" height="22" rx="2" fill="#D0F451"/><g fill="#1A1A1A"><path d="M14.262 17c-.48 0-1.001-.027-1.735-.107v-1.215a18.96 18.96 0 001.709.094c1.375 0 2.056-.494 2.056-1.496 0-.667-.32-1.148-1.202-1.709l-1.055-.667c-1.028-.668-1.535-1.455-1.535-2.443C12.5 7.92 13.635 7 15.57 7c.401 0 .842.04 1.376.107v1.161a10.456 10.456 0 00-1.335-.106c-1.202 0-1.816.44-1.816 1.268 0 .574.307 1.001 1.068 1.482l.961.6c1.215.775 1.776 1.643 1.776 2.751 0 1.736-1.228 2.737-3.338 2.737zM19.667 16.893V7.107h2.67c1.976 0 3.218 1.108 3.218 2.897 0 1.749-1.242 2.857-3.218 2.857H20.95v4.032h-1.282zm1.282-5.207h1.362c1.228 0 1.922-.614 1.922-1.682 0-1.055-.694-1.682-1.922-1.682h-1.362v3.364z"/></g></svg>

<br>
<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" role="img" viewBox="0 0 38 24" width="38" height="24" fill="none" aria-labelledby="pi-simplepay" version="1.1"><title id="pi-simplepay">Simple Pay</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z" fill="#000"/><rect x="1" y="1" width="36" height="22" rx="2" fill="#D0F451"/><g fill="#1A1A1A"><path d="M14.262 17c-.48 0-1.001-.027-1.735-.107v-1.215a18.96 18.96 0 001.709.094c1.375 0 2.056-.494 2.056-1.496 0-.667-.32-1.148-1.202-1.709l-1.055-.667c-1.028-.668-1.535-1.455-1.535-2.443C12.5 7.92 13.635 7 15.57 7c.401 0 .842.04 1.376.107v1.161a10.456 10.456 0 00-1.335-.106c-1.202 0-1.816.44-1.816 1.268 0 .574.307 1.001 1.068 1.482l.961.6c1.215.775 1.776 1.643 1.776 2.751 0 1.736-1.228 2.737-3.338 2.737zM19.667 16.893V7.107h2.67c1.976 0 3.218 1.108 3.218 2.897 0 1.749-1.242 2.857-3.218 2.857H20.95v4.032h-1.282zm1.282-5.207h1.362c1.228 0 1.922-.614 1.922-1.682 0-1.055-.694-1.682-1.922-1.682h-1.362v3.364z"/></g></svg>
</br>

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify? ASAP

hellicarusprime commented 7 months ago

Hey @dalindev—you've got a double border on the icon. Please update.

image
dalindev commented 7 months ago

Hey @hellicarusprime, we have updated the icon, and attached the latest screenshot, it is fixed now. thank you!