Closed resolveeng closed 5 months ago
@resolveeng The way you're applying the border to the icon doesn't look right. Please refer to our contributing guidelines and update.
@hellicarusprime Thanks for the feedback. We applied the #00000 0.07 2px border radius stroke. However, we noticed that making the border radius outside as requested in the guidelines made the dimensions of our logo appear bigger when applied (but the dimensions are still technically 38x24). Because of this, we wanted to know if it would be better to send a logo that is technically 37x23 but 'looks' correct. I've attached a photo for reference. Looking forward to your reply!
Hey @resolveeng an approach that works for some is to use a background layer for the border, which is 38 x 24 and another layer for the inner portion (see attached screenshot).
Thank you @hellicarusprime . I have pushed a new commit to the PR.
Hey @resolveeng—to ensure we have the correct 2 px border-radius, the background layer should be 36 x 22 with the 1 px border applied to the outside. This will make it the appropriate 38 x 24. Apologies for any confusion.
@hellicarusprime just pushed new commit with the suggested fix. Please let me know if that meets the requirements. Thank you.
Hey @resolveeng, there's still something off with it. This might help to explain things more clearly.
@hellicarusprime just pushed a fix. Please let us know if that looks better. Apologies for the back and forth.
hello @hellicarusprime , any idea of when this is going to be available in the Shopify partners portal? Thank you.
hello @hellicarusprime @adeniyiao any idea of when a new release will come out with the new logos?
Hi @resolveeng ,
The PR is failing some tests with error below. Could you please address. Thanks
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]:
{:message=>"The 'clip0_17506_909' ID should be pi-resolvepay-clip0_17506_909 (missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "clip0_17506_909".
thank you @adeniyiao . I have pushed a fix to the ID as requested. Can you check if tests are successful now?
hello @hellicarusprime @adeniyiao is there anything else you need from our end to create a new release? Thank you.
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines: https://www.figma.com/file/Wt7KZnuPr0UlZZ3beBUG43/Brand-guide?type=design&node-id=2%3A258&mode=design&t=J2IuHLm01uIQ7r0D-1
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Screenshot:
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?