Closed eduard-ca closed 6 months ago
Hi @eduard-ca, there are a couple of things that need to be resolved before I can approve.
Can you please update the name in the YML file for Progressive Leasing? It shouldn't have any special characters, including dashes, spaces or underscores. This is a change we've made to the contributing guidelines.
It also looks like the border is uneven on both of the icons.
Hi @hellicarusprime
I updated Progressive Leasing name, thanks for review.
It also looks like the border is uneven on both of the icons.
Could you please explain what is wrong here to make correct changes?
Thanks!
@hellicarusprime We updated the icon alignment. Please review it again
Thanks
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Screenshot:![Screenshot 2024-02-09 155344](https://github.com/activemerchant/payment_icons/assets/81959588/26c1e603-3dc6-4e47-95f3-6b8694e7062f)
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?