Add payrexx requested icons

sven-otziger commented 6 months ago

Why are you adding these icons?

I'm adding/updating these icons because we as a payment service provider are offering these payment methods and would like to offer them in Shopify as well.

Help us identify yourself

[ ] I'm working/collaborating with the brand directly and they have provided the icons.
[x] I'm associated with the brand and I've read all the brand icon’s guidelines.
[ ] I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

https://www.figma.com/community/file/1215439650104209045/centi-brand-guidelines
https://reka.ch/en/rekamoney/about-us/media/press
The logo for the payment method Bank Transfer was created internally.

Checklist to add new icons

[x] All icons have a corresponding entry in db/payment_icons.yml
[x] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
[x] I have optimized the icon with SVGO
[x] I am confident that all icons are clear and easy to read/understand
[x] I have provided a link to the brand icon’s brand guidelines whenever possible.
[x] I have attached a screenshot comparison with the example icon provided in guidelines
[x] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

comparison_bank_transfer_black_cropped comparison_bank_transfer_white_cropped comparison_centi_black_cropped comparison_centi_white_cropped comparison_reka_black_cropped comparison_reka_white_cropped

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) We don't have a direct contact at Shopify. We are just acting as a Shopify partner.

What's the expected date of this change to deploy on Shopify? We would like the icons released at your earliest convenience.

hellicarusprime commented 5 months ago

Hi @sven-otziger, Bank transfer is overly generic for a name and label. Who is the payment provider? We also no longer allow underscores in names. See our contributing guidelines.

sven-otziger commented 5 months ago

Hi @hellicarusprime

Bank transfer is our internally developed payment method to accept payment by bank transfer. Customers receive an invoice for their purchase. Our system then checks the transactions of our bank account and adjusts the status in our system accordingly. It would be dissatisfying if we would need to adjust the naming here and introduce inconsistency. Can we find a compromise and adjust merely the name of the payment method so it stays the same for our customers?

hellicarusprime commented 5 months ago

Cc: @adeniyiao—what are your thoughts here?

adeniyiao commented 5 months ago

Cc: @adeniyiao—what are your thoughts here?

I will suggest using another name instead of generic bank transfer, so if there is a custom name for the bank transfer payment method, please use it. Also, please change the name without any special characters, please see guidelines

sven-otziger commented 5 months ago

Hi @hellicarusprime @adeniyiao I updated the pointed out issues.

hellicarusprime commented 5 months ago

Hi @hellicarusprime @adeniyiao I updated the pointed out issues.

Hi @sven-otziger Can you please update the name of the SVG to be the same as the name entered in db/payment_icons.yml? The SVG still contains underscores.

Lovedanihonjin commented 4 months ago

Awesome. Thanks for your changes. Approved. Next deploy is on June 5.

sven-otziger commented 4 months ago

@Lovedanihonjin Many thanks

activemerchant / payment_icons