Closed sven-otziger closed 4 months ago
Hi @sven-otziger, Bank transfer
is overly generic for a name and label. Who is the payment provider? We also no longer allow underscores in names. See our contributing guidelines.
Hi @hellicarusprime
Bank transfer is our internally developed payment method to accept payment by bank transfer. Customers receive an invoice for their purchase. Our system then checks the transactions of our bank account and adjusts the status in our system accordingly. It would be dissatisfying if we would need to adjust the naming here and introduce inconsistency. Can we find a compromise and adjust merely the name of the payment method so it stays the same for our customers?
Cc: @adeniyiao—what are your thoughts here?
Cc: @adeniyiao—what are your thoughts here?
I will suggest using another name instead of generic bank transfer, so if there is a custom name for the bank transfer payment method, please use it. Also, please change the name without any special characters, please see guidelines
Hi @hellicarusprime @adeniyiao I updated the pointed out issues.
Hi @hellicarusprime @adeniyiao I updated the pointed out issues.
Hi @sven-otziger Can you please update the name of the SVG to be the same as the name entered in db/payment_icons.yml? The SVG still contains underscores.
Awesome. Thanks for your changes. Approved. Next deploy is on June 5.
@Lovedanihonjin Many thanks
Why are you adding these icons?
I'm adding/updating these icons because we as a payment service provider are offering these payment methods and would like to offer them in Shopify as well.
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) We don't have a direct contact at Shopify. We are just acting as a Shopify partner.
What's the expected date of this change to deploy on Shopify? We would like the icons released at your earliest convenience.