Open vponline opened 6 months ago
Hi @vponline there is already an HSBC logo available so you don't need to add another one. Please update and I'll review.
@vponline I noticed that the icons you want to add are missing a visible border. Please refer to this section of our contributing guidelines.
@hellicarusprime fixes have been applied, please check again 🙏
Are there any further changes required to get these accepted please?
Are there any further changes required to get these accepted please?
@vponline are you able to address the following test failures?
Failure: PaymentIconTest#test_Every_payment_icon_record_has_a_corresponding_SVG_file [test/unit/payment_icon_test.rb:25]: Expected false to be truthy.
rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:23
..F
Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]: {:message=>"The 'clip039228' ID should be pi-abn-clip0_39_228 (missing 'pi-' prefix)"}. Expected /pi-(.*)/ to match "clip0_39_228".
Ok that should be fixed now
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines: Volt Design Guidelines
Checklist to add new icons
db/payment_icons.yml
Attach a screenshot of the icon along side the example Visa icon